Extend posting-group-max-key-series-ratio for add all posting group #8083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yeya24 <[email protected]>
alanprot
approved these changes
Jan 31, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We introduced
posting-group-max-key-series-ratioin #7961 to mark a posting group as lazy if it fetches a lot of keys. But at that time, it was only applied for posting group with add keys for example=~".+"or!="".The same problem of fetching a lot of postings and unable to be optimized can also occur for posting groups with remove keys. We had an issue with matcher
pod=~""which ended up becoming an add all posting group with removing all postings forpodlabel. This requires fetching a lot of keys and unable to be optimized. This PR should apply the same optimization and solve the issue here.Verification